Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
dynamikdev
force-pushed
the
implement-meyer-square-8719865916247423350
branch
from
6ff2b92 to
5141b39
Compare
- Add `MeyerSequence`, `MeyerNode`, and `TechniqueType` structs to `src/resources.rs`. - Define the 4 concentric 4-strike sequences based on historical data in `src/constants.rs`. - Introduce `TrainingWorkflow` enum to toggle between `Circular` and `MeyerSquare` modes. - Implement UI toggle in `src/ui/settings.rs` and `workflow_toggle_system` in `src/ui/systems.rs`. - Refactor target rendering to hide circular targets when Meyer's Square mode is active. - Render the Meyer's Square geometric grid and "Ghost of Meyer" visual signatures (Cut, Thrust, Parry) using Bevy gizmos in `src/ui/systems.rs`. - Implement sequence logic to cycle through nodes and sequences based on rhythm duration in `src/logic.rs`. - Add unit tests for Meyer sequence logic in `src/logic_test.rs`. Co-authored-by: dynamikdev <717692+dynamikdev@users.noreply.github.com>
- Update `render_meyer_square` in `src/ui/systems.rs` to ensure Cut and Thrust visual lines span to the edges of the outermost bounding square, regardless of the active node's concentric ring (calculated using coordinate signum). - Update the Parry (Shield) block to fill the entire quadrant of the bounding square instead of just a small box at the exact node coordinate. Co-authored-by: dynamikdev <717692+dynamikdev@users.noreply.github.com>
dynamikdev
force-pushed
the
implement-meyer-square-8719865916247423350
branch
from
e5e5ca3 to
eeef1cc
Compare
1 participant
Implement a second training workflow based on the 16th-century Meyer's Square diagram. This workflow replaces the circular 8-point system with a four-quadrant concentric grid. The interaction is visual-only, featuring a "Ghost of Meyer" guide that indicates the path and technique (cut, thrust, parry) the user should execute. Users can switch between the Circular and Meyer's Square workflows via a toggle in the settings panel.
PR created automatically by Jules for task 8719865916247423350 started by @dynamikdev