fix(imap-codec): Mail.ru FETCH interop (quoted empty, NIL body-fld-param)#701
Closed
FreakyStudio wants to merge 3 commits intoduesee:mainfrom
Closed
fix(imap-codec): Mail.ru FETCH interop (quoted empty, NIL body-fld-param)#701FreakyStudio wants to merge 3 commits intoduesee:mainfrom
FreakyStudio wants to merge 3 commits intoduesee:mainfrom
Conversation
…ram) Accept empty quoted strings in addresses; quirk for NIL in body-fld-param pairs; regression tests and fixture. Fixes duesee#700. Made-with: Cursor
- Add .gitattributes binary for wire fixture so Unix checkouts keep CRLF. - Replace len-2 chop with testing::trim_line_end for substring tests. - Assert CRLF on full-line decode tests; register quirk in justfile cargo hack. Made-with: Cursor
Git can store the capture as LF-only; strict IMAP parsers need CRLF. Made-with: Cursor
Collaborator
Pull Request Test Coverage Report for Build 23582211110Details
💛 - Coveralls |
Owner
|
Nope, sorry. Too much code that feels LLM-generated. Not going to review. Also: My motivation to spend energy on mail.ru is quite low. If you can pinpoint exactly what is the problem with reproducers and a PR that is easy to review, I'll merge it. Otherwise not going to spend time on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #700.
Changes
quoted()— Parse empty quoted strings ("") per RFC 3501*QUOTED-CHAR, fixing envelope addresses from Mail.ru.quirk_body_fld_param_nil_value(defaultquirkfeature) — AllowNILas the value inbody-fld-parampairs, e.g.("boundary" NIL)inBODYSTRUCTURE.FETCHrepro; integration test + binary fixture for a real nestedmultipart/mixed→multipart/alternativeline;fetchunit tests slicing envelope vsBODYSTRUCTURE;responseparses full line.Notes
cargo +nightly fmtandcargo testunderimap-codec/.Maintainers: happy to drop or shrink the binary fixture if you prefer a purely
concat!-based line.