fix: add -XstartOnFirstThread to UI launch configs for macOS#1283
Draft
joaodinissf wants to merge 7 commits intodsldevkit:masterfrom
Draft
fix: add -XstartOnFirstThread to UI launch configs for macOS#1283joaodinissf wants to merge 7 commits intodsldevkit:masterfrom
joaodinissf wants to merge 7 commits intodsldevkit:masterfrom
Conversation
On macOS (Cocoa), SWT requires the Display to be created on the main thread. Without -XstartOnFirstThread, all RuntimeWorkbench and SWTBot launch configs fail with "Invalid thread access". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SunOS/Solaris is no longer a relevant target platform. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a macosx profile activated on family=mac that sets OSGI properties (macosx/cocoa/aarch64) and appends -XstartOnFirstThread to test JVM options, fixing SWTException: Invalid thread access on macOS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The maven-clean-plugin deletes everything under xtend-gen/ including the .gitignore placeholder files that keep these directories tracked by git. Exclude .gitignore from the clean fileset so that running mvn clean no longer causes dirty working tree status. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
On macOS, SWT Cocoa's modal event loop inside WizardDialog.open() blocks Display.sleep() on NSRunLoop.runMode(distantFuture). SWTBot's syncExec-based polling cannot reliably wake this up without OS focus. This is consistent with Eclipse Foundation practice: SWTBot wizard tests run on Linux CI (with xvfb), not on macOS. Revert SwtWizardBot to the original simple implementation and add @DisabledOnOs(OS.MAC) to CheckProjectWizardTest and CheckCatalogWizardTest. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These .tycho-consumer-pom.xml files are generated during mvn builds and should not be tracked. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joaodinissf
force-pushed
the
fix/start-on-first-thread
branch
from
faa451c to
7bce3ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-XstartOnFirstThreadVM argument to all RuntimeWorkbench and SWTBot launch configurationsSWTException: Invalid thread accessAffected files (7)
ddk-configuration/launches/devkit-run.launchcom.avaloq.tools.ddk.sample.helloworld/.launch/Launch Runtime Eclipse.launchcom.avaloq.tools.ddk.check.ui.test/CheckUiTestSuite.launchcom.avaloq.tools.ddk.checkcfg.ui.test/CheckCfgUiTestSuite.launchcom.avaloq.tools.ddk.test.ui.test/AllTests.launchcom.avaloq.tools.ddk.xtext.test/AllTests DDK.launchcom.avaloq.tools.ddk.xtext.ui.test/XtextUiTestSuite.launchTest plan
devkit-runlaunches successfully on macOS with this changexvfb-run)🤖 Generated with Claude Code