Skip to content

fix: handle shallow export resource URIs in ExportGeneratorX#1281

Draft
joaodinissf wants to merge 1 commit intodsldevkit:masterfrom
joaodinissf:fix/export-generatorx-uri-guard
Draft

fix: handle shallow export resource URIs in ExportGeneratorX#1281
joaodinissf wants to merge 1 commit intodsldevkit:masterfrom
joaodinissf:fix/export-generatorx-uri-guard

Conversation

@joaodinissf
Copy link
Copy Markdown
Collaborator

@joaodinissf joaodinissf commented Mar 3, 2026

Summary

  • fix the pre-existing IllegalArgumentException in ExportGeneratorX for shallow platform:/resource/<project>/<file>.export URIs
  • keep the existing package derivation for resources under src/<java package>/...
  • fall back to a sanitized project-name package for root-level .export files
  • add a regression test for the root-level test resource URI shape

Verification

  • env WORKSPACE=$(pwd) mvn -f ./ddk-parent/pom.xml -pl :ddk-target,:com.avaloq.tools.ddk.test.core,:com.avaloq.tools.ddk.xtext.test.core,:com.avaloq.tools.ddk.xtext.export,:com.avaloq.tools.ddk.xtext.export.ui,:com.avaloq.tools.ddk.xtext.export.test -am verify -DfailIfNoTests=false

Limitations

  • this verifies compilation and packaging of the affected bundles, but com.avaloq.tools.ddk.xtext.export.test does not execute tests in this reactor because it inherits tycho-surefire-plugin skip=true from ddk-parent
  • running the actual Tycho UI test runner is currently blocked by an unrelated existing master compile failure in com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/naming/QualifiedNameSegmentTreeLookupTest.java

@joaodinissf joaodinissf changed the title fix: harden ExportGeneratorX package derivation fix: handle shallow export resource URIs in ExportGeneratorX Mar 3, 2026
@joaodinissf joaodinissf marked this pull request as draft March 3, 2026 21:01
@joaodinissf joaodinissf force-pushed the fix/export-generatorx-uri-guard branch from 0f6cf8b to 5b9f831 Compare March 3, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant