Skip to content

fix: add SLF4J NOP binding to target, clean up stale imports #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joaodinissf wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −6
Draft

fix: add SLF4J NOP binding to target, clean up stale imports #1280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions com.avaloq.tools.ddk.check.ui.test/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ Require-Bundle: com.avaloq.tools.ddk.check.ui,
Export-Package: com.avaloq.tools.ddk.check.ui.test,
com.avaloq.tools.ddk.check.ui.test.util,
com.avaloq.tools.ddk.check
Import-Package: org.slf4j,
org.hamcrest.core,
Import-Package: org.hamcrest.core,
org.junit.runner;version="4.5.0",
org.junit.runner.manipulation;version="4.5.0",
org.junit.runner.notification;version="4.5.0",
Expand Down
2 changes: 1 addition & 1 deletion com.avaloq.tools.ddk.xtext.test.core/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Require-Bundle: com.avaloq.tools.ddk.xtext,
org.eclipse.emf.common,
com.avaloq.tools.ddk,
junit-jupiter-api
Import-Package: org.slf4j, org.apache.logging.log4j
Import-Package: org.apache.logging.log4j
Export-Package: com.avaloq.tools.ddk.xtext.test,
com.avaloq.tools.ddk.xtext.test.contentassist,
com.avaloq.tools.ddk.xtext.test.conversion,
Expand Down
3 changes: 1 addition & 2 deletions com.avaloq.tools.ddk.xtext.test/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ Import-Package: com.avaloq.tools.ddk.check.runtime.test.core,
com.avaloq.tools.ddk.xtext.test.export,
com.avaloq.tools.ddk.xtext.test.format,
com.avaloq.tools.ddk.xtext.ui.test,
org.apache.logging.log4j,
org.slf4j
org.apache.logging.log4j
Export-Package: com.avaloq.tools.ddk.xtext,
com.avaloq.tools.ddk.xtext.formatter,
com.avaloq.tools.ddk.xtext.formatter.services,
Expand Down
3 changes: 2 additions & 1 deletion ddk-target/ddk.target
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
<unit id="org.apache.commons.lang3" version="3.20.0"/>
<unit id="org.apache.logging.log4j.core" version="2.25.3"/>
<unit id="org.apache.logging.log4j.api" version="2.25.3"/>
<unit id="org.apache.log4j" version="1.2.26"/> <!--use reload4j 1.2.26 for org.eclipse.xtext dependencies to log4j-->
<unit id="org.apache.log4j" version="1.2.26"/> <!--use reload4j 1.2.26 for org.eclipse.xtext dependencies to log4j-->
<unit id="slf4j.nop" version="2.0.17"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/tools/orbit/simrel/maven-osgi/release/4.39.0"/>
Expand Down
Loading