perf: avoid AST traversal to fill the IdToEObjectMap in the rootNode#1085
Closed
rubenporras wants to merge 1 commit intodsldevkit:masterfrom
Closed
perf: avoid AST traversal to fill the IdToEObjectMap in the rootNode#1085rubenporras wants to merge 1 commit intodsldevkit:masterfrom
rubenporras wants to merge 1 commit intodsldevkit:masterfrom
Conversation
rubenporras
force-pushed
the
astTraversal
branch
from
1c9eb27 to
97eb770
Compare
joaodinissf
reviewed
Feb 14, 2025
....tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/ProxyCompositeNode.java
Outdated
Show resolved
Hide resolved
....tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/ProxyCompositeNode.java
Outdated
Show resolved
Hide resolved
....tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/ProxyCompositeNode.java
Outdated
Show resolved
Hide resolved
joaodinissf
reviewed
Feb 14, 2025
...rc/com/avaloq/tools/ddk/xtext/resource/persistence/DirectLinkingResourceStorageLoadable.java
Show resolved
Hide resolved
rubenporras
force-pushed
the
astTraversal
branch
from
97eb770 to
fd9af71
Compare
joaodinissf
previously approved these changes
Feb 14, 2025
rubenporras
force-pushed
the
astTraversal
branch
2 times, most recently
from
6da39a9 to
4fe94ec
Compare
Member
Author
|
Cc: @andrewL-avlq |
| // case EOBJECT_CONTAINER_PROXY_RESOLVING: | ||
| // | ||
| default: | ||
| l.add(internalEObject); |
Collaborator
There was a problem hiding this comment.
InternalEObject is at the wrong end of the feature. This is why the set you have collected is never big enough.
rubenporras
force-pushed
the
astTraversal
branch
7 times, most recently
from
cc34827 to
4b120cf
Compare
rubenporras
force-pushed
the
astTraversal
branch
from
4b120cf to
0044c17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.