fix(native): validate range content at parse time#19
Open
phdavis1027 wants to merge 1 commit intodryruby:developfrom
Open
fix(native): validate range content at parse time#19phdavis1027 wants to merge 1 commit intodryruby:developfrom
phdavis1027 wants to merge 1 commit intodryruby:developfrom
Conversation
The native parser'ss terminal method accepted any content between [ and ] without validation. This meant invalid ranges like [-abc] were silently accepted instead of raising SyntaxError, despite the RANGE regex in terminals.rb correctly rejecting them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native parser'ss terminal method accepted any content between [ and ] without validation. This meant invalid ranges like [-abc] were silently accepted instead of raising SyntaxError, despite the RANGE regex in terminals.rb correctly rejecting them.