Fix test instructions, and refactor tests for consistency#9
Open
adamserafini wants to merge 5 commits intodropbox:masterfrom
Open
Fix test instructions, and refactor tests for consistency#9adamserafini wants to merge 5 commits intodropbox:masterfrom
adamserafini wants to merge 5 commits intodropbox:masterfrom
Conversation
This commit makes tests/test_basic.py more similar to the other test files in the test directory. Ie. instead of using unittest, tests are just asserts in functions that can be run by pytest.
Refactor test_rss.py to be more similar to the other tests, ie. the tests are asserts in functions.
Running test_errors.py with pytest generates the complaint that using yield in tests is deprecated. On closer inspection, test_errors.py can be simplified by embedding a multiline string with the error case in each test function.
10 tasks
lfaraone
pushed a commit
that referenced
this pull request
Oct 1, 2019
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple of problems with the instructions for running tests in the current project README:
pyxl_tests.pywas renamedtests\test_basic.pyIt seems the newer tests have a different 'style' to the original
pyxl_tests.py: the new tests usepytest-style, ie. plain asserts in functions rather than theunittest2-style consisting ofassertEqualetc.This suggests that the intended way of running the full test suite is with
pytest.This PR does the following:
a. Makes the test suite consistent with itself: changes any use of
unittest2style testing topyteststyle testing comprised of asserts in functions and removes anyunittest2dependencies.b. Adds instructions to the README for running the full test suite.