chore: Update dependencies for improved compatibility and performance by doubleailes · Pull Request #148 · doubleailes/girolle

doubleailes · 2025-05-03T08:06:03Z

PR Type

enhancement, dependencies

Description

Updated multiple dependencies to newer versions across workspace.
Improved compatibility and performance by aligning with latest crates.
Ensured all workspace members use updated shared dependencies.

Changes walkthrough 📝

Relevant files

Dependencies

Cargo.toml `Update workspace dependency versions` Cargo.toml Bumped `serde_json` from 1.0.133 to 1.0.140. Updated `tokio` from 1.42.0 to 1.44.2. Upgraded `serde` from 1.0.216 to 1.0.219.	+3/-3
Cargo.toml `Bump and synchronize crate dependencies` girolle/Cargo.toml Upgraded `lapin` from 2.5.0 to 2.5.3. Updated `serde_yaml` from 0.9.33 to 0.9.34+deprecated. Bumped `regex` from 1.11.0 to 1.11.1. Upgraded `uuid` from 1.11.0 to 1.16.0. Synchronized workspace dependencies for `serde`, `serde_json`, and `tokio`.	+4/-4
Cargo.toml `Update proc-macro dependencies to latest versions` girolle_macro/Cargo.toml Upgraded `proc-macro2` from 1.0.92 to 1.0.95. Updated `quote` from 1.0.37 to 1.0.40. Bumped `syn` from 2.0.90 to 2.0.101. Ensured `serde_json` uses workspace version.	+3/-3

Need help?
Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
Check out the documentation for more information.

qodo-code-review · 2025-05-03T08:06:22Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 147 - Fully compliant Compliant requirements: Update libraries/dependencies to newer versions
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Deprecated Package The serde_yaml dependency is updated to a version marked as deprecated (0.9.34+deprecated). This might indicate that the package is no longer maintained or has known issues. serde_yaml = "0.9.34+deprecated" regex = "1.11.1"

qodo-code-review · 2025-05-03T08:06:25Z

PR Code Suggestions ✨

No code suggestions found for the PR.

qodo-code-review · 2025-05-03T08:06:29Z

Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: dry_publish
Failed stage: Run katyo/publish-crates@v2 [❌]
Failure summary: The action failed because the `katyo/publish-crates` GitHub action detected consistency errors in two packages: 1. The `girolle` package has been modified since version 1.8.4 but the version number hasn't been updated 2. The `girolle_macro` package has been modified since version 1.8.4 but the version number hasn't been updated The action expects that when code changes are made to a package, its version number should be incremented before publishing.
Relevant error logs: 1: ##[group]Operating System 2: Ubuntu ... 160: ##[endgroup] 161: ##[group]Run katyo/publish-crates@v2 162: with: 163: dry-run: true 164: token: *** 165: path: . 166: check-repo: true 167: publish-delay: 0 168: no-verify: false 169: ignore-unpublished-changes: false 170: env: 171: CARGO_TERM_COLOR: always 172: ##[endgroup] 173: Searching cargo packages at '.' 174: [command]/home/runner/.cargo/bin/cargo metadata --no-deps --format-version 1 --manifest-path Cargo.toml 175: {"packages":[{"name":"girolle","version":"1.8.4","id":"path+file:///home/runner/work/girolle/girolle/girolle#1.8.4","license":null,"license_file":"../LICENSE","description":"A nameko like lib in rust","source":null,"dependencies":[{"name":"futures","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^0.3.31","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null},{"name":"girolle_macro","source":null,"req":"^1.8","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null,"path":"/home/runner/work/girolle/girolle/girolle_macro"},{"name":"lapin","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^2.5.3","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null},{"name":"regex","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.11.1","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null},{"name":"serde","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.0.219","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":["derive","rc"],"target":null,"registry":null},{"name":"serde_json","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.0.140","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null},{"name":"serde_yaml","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^0.9.34","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null},{"name":"tokio","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.44.2","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":["full"],"target":null,"registry":null},{"name":"tokio-executor-trait","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^2.1.3","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null},{"name":"tokio-reactor-trait","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.1.0","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null},{"name":"tracing","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^0.1.41","kind":null,"rename":null,"optional":false,"uses_default_features":false,"features":[],"target":null,"registry":null},{"name":"tracing-subscriber","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^0.3.19","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":["fmt"],"target":null,"registry":null},{"name":"uuid","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.16.0","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":["v4","fast-rng"],"target":null,"registry":null},{"name":"criterion","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^0.5.1","kind":"dev","rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null}],"targets":[{"kind":["lib"],"crate_types":["lib"],"name":"girolle","src_path":"/home/runner/work/girolle/girolle/girolle/src/lib.rs","edition":"2021","doc":true,"doctest":true,"test":true},{"kind":["bench"],"crate_types":["bin"],"name":"macro","src_path":"/home/runner/work/girolle/girolle/girolle/benches/macro.rs","edition":"2021","doc":false,"doctest":false,"test":false}],"features":{},"manifest_path":"/home/runner/work/girolle/girolle/girolle/Cargo.toml","metadata":null,"publish":null,"authors":["Philippe Llerena <philippe.llerena@gmail.com>"],"categories":[],"keywords":[],"readme":"../README.md","repository":null,"homepage":null,"documentation":null,"edition":"2021","links":null,"default_run":null,"rust_version":null},{"name":"girolle_macro","version":"1.8.4","id":"path+file:///home/runner/work/girolle/girolle/girolle_macro#1.8.4","license":null,"license_file":"../LICENSE","description":"A nameko macro proc-macro to generate a Nameko Function","source":null,"dependencies":[{"name":"proc-macro2","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.0.95","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null},{"name":"quote","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.0.40","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null},{"name":"serde_json","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.0.140","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null},{"name":"syn","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^2.0.101","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":["fold","full"],"target":null,"registry":null}],"targets":[{"kind":["proc-macro"],"crate_types":["proc-macro"],"name":"girolle_macro","src_path":"/home/runner/work/girolle/girolle/girolle_macro/src/lib.rs","edition":"2021","doc":true,"doctest":true,"test":true}],"features":{},"manifest_path":"/home/runner/work/girolle/girolle/girolle_macro/Cargo.toml","metadata":null,"publish":null,"authors":[],"categories":[],"keywords":[],"readme":"../README.md","repository":null,"homepage":null,"documentation":null,"edition":"2021","links":null,"default_run":null,"rust_version":null},{"name":"examples","version":"0.0.0","id":"path+file:///home/runner/work/girolle/girolle/examples#0.0.0","license":null,"license_file":null,"description":null,"source":null,"dependencies":[{"name":"tracing","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^0.1.40","kind":null,"rename":null,"optional":false,"uses_default_features":false,"features":[],"target":null,"registry":null},{"name":"tracing-subscriber","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^0.3.18","kind":null,"rename":null,"optional":false,"uses_default_features":true,"features":["fmt"],"target":null,"registry":null},{"name":"girolle","source":null,"req":"*","kind":"dev","rename":null,"optional":false,"uses_default_features":true,"features":[],"target":null,"registry":null,"path":"/home/runner/work/girolle/girolle/girolle"},{"name":"serde","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.0.219","kind":"dev","rename":null,"optional":false,"uses_default_features":true,"features":["derive","rc"],"target":null,"registry":null},{"name":"tokio","source":"registry+https://github.com/rust-lang/crates.io-index","req":"^1.44.2","kind":"dev","rename":null,"optional":false,"uses_default_features":true,"features":["full"],"target":null,"registry":null}],"targets":[{"kind":["example"],"crate_types":["bin"],"name":"async_test","src_path":"/home/runner/work/girolle/girolle/examples/src/async_test.rs","edition":"2021","doc":false,"doctest":false,"test":false},{"kind":["example"],"crate_types":["bin"],"name":"error_sender","src_path":"/home/runner/work/girolle/girolle/examples/src/error_sender.rs","edition":"2021","doc":false,"doctest":false,"test":false},{"kind":["example"],"crate_types":["bin"],"name":"simple_fib","src_path":"/home/runner/work/girolle/girolle/examples/src/simple_fib.rs","edition":"2021","doc":false,"doctest":false,"test":false},{"kind":["example"],"crate_types":["bin"],"name":"simple_macro","src_path":"/home/runner/work/girolle/girolle/examples/src/simple_macro.rs","edition":"2021","doc":false,"doctest":false,"test":false},{"kind":["example"],"crate_types":["bin"],"name":"simple_sender","src_path":"/home/runner/work/girolle/girolle/examples/src/simple_sender.rs","edition":"2021","doc":false,"doctest":false,"test":false},{"kind":["example"],"crate_types":["bin"],"name":"simple_service","src_path":"/home/runner/work/girolle/girolle/examples/src/simple_service.rs","edition":"2021","doc":false,"doctest":false,"test":false}],"features":{},"manifest_path":"/home/runner/work/girolle/girolle/examples/Cargo.toml","metadata":null,"publish":[],"authors":[],"categories":[],"keywords":[],"readme":null,"repository":null,"homepage":null,"documentation":null,"edition":"2021","links":null,"default_run":null,"rust_version":null}],"workspace_members":["path+file:///home/runner/work/girolle/girolle/girolle#1.8.4","path+file:///home/runner/work/girolle/girolle/girolle_macro#1.8.4","path+file:///home/runner/work/girolle/girolle/examples#0.0.0"],"workspace_default_members":["path+file:///home/runner/work/girolle/girolle/girolle#1.8.4","path+file:///home/runner/work/girolle/girolle/girolle_macro#1.8.4","path+file:///home/runner/work/girolle/girolle/examples#0.0.0"],"resolve":null,"target_directory":"/home/runner/work/girolle/girolle/target","version":1,"workspace_root":"/home/runner/work/girolle/girolle","metadata":null} 176: { ... 250: "req": "^1.0.40" 251: }, 252: "serde_json": { 253: "kind": null, 254: "req": "^1.0.140" 255: }, 256: "syn": { 257: "kind": null, 258: "req": "^2.0.101" 259: } 260: } 261: } 262: } 263: Found packages: girolle, girolle_macro 264: Checking packages consistency 265: ##[error]It seems package 'girolle' modified since '1.8.4' so new version should be published 266: ##[error]It seems package 'girolle_macro' modified since '1.8.4' so new version should be published 267: ##[error]Error: Found 2 packages with consistency errors: girolle girolle_macro 268: Post job cleanup.

Copilot

Pull Request Overview

This PR updates various workspace dependencies to improve compatibility and performance across the project.

Bumped dependency versions in the root Cargo.toml for serde_json, tokio, and serde.
Updated crate versions in girolle/Cargo.toml for lapin, serde_yaml (noting the "+deprecated" suffix), regex, and uuid.
Upgraded proc-macro dependencies in girolle_macro/Cargo.toml for proc-macro2, quote, and syn.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
Cargo.toml	Updated workspace dependency versions.
girolle/Cargo.toml	Synchronized and updated crate dependency versions.
girolle_macro/Cargo.toml	Upgraded proc-macro dependency versions.

Copilot · 2025-05-03T08:06:45Z

girolle/Cargo.toml

 tokio-reactor-trait = "1.1.0"
-serde_yaml = "0.9.33"
-regex = "1.11.0"
+serde_yaml = "0.9.34+deprecated"


Using a dependency version marked as '+deprecated' could lead to future issues; consider adding a comment for clarification or planning a migration strategy if the deprecation is not intended.

Suggested change

serde_yaml = "0.9.34+deprecated"

serde_yaml = "0.9.34+deprecated" # This version is deprecated. Consider updating to a non-deprecated version or planning a migration strategy.

chore: Update dependencies for improved compatibility and performance

e1c8386

doubleailes linked an issue May 3, 2025 that may be closed by this pull request

Update libs #147

Closed

doubleailes requested a review from Copilot May 3, 2025 08:06

qodo-code-review bot added the Review effort 1/5 label May 3, 2025

Copilot AI reviewed May 3, 2025

View reviewed changes

chore: Bump version to 1.8.5 for girolle and girolle_macro packages

de1cddb

doubleailes merged commit 980ba91 into main May 3, 2025
5 checks passed

doubleailes deleted the 147-update-libs branch May 3, 2025 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update dependencies for improved compatibility and performance#148

chore: Update dependencies for improved compatibility and performance#148
doubleailes merged 2 commits intomainfrom
147-update-libs

doubleailes commented May 3, 2025 •

edited by qodo-code-review bot

Loading

Uh oh!

qodo-code-review bot commented May 3, 2025

Uh oh!

qodo-code-review bot commented May 3, 2025 •

edited

Loading

Uh oh!

qodo-code-review bot commented May 3, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	serde_yaml = "0.9.34+deprecated"
	serde_yaml = "0.9.34+deprecated" # This version is deprecated. Consider updating to a non-deprecated version or planning a migration strategy.

Conversation

doubleailes commented May 3, 2025 • edited by qodo-code-review bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Description

Changes walkthrough 📝

Uh oh!

qodo-code-review bot commented May 3, 2025

PR Reviewer Guide 🔍

Uh oh!

qodo-code-review bot commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Uh oh!

qodo-code-review bot commented May 3, 2025

CI Feedback 🧐

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

doubleailes commented May 3, 2025 •

edited by qodo-code-review bot

Loading

qodo-code-review bot commented May 3, 2025 •

edited

Loading