Fix TypeInitializationException when system has duplicate font names#121
Open
punker76 wants to merge 1 commit intodotnetprojects:masterfrom
Open
Fix TypeInitializationException when system has duplicate font names#121punker76 wants to merge 1 commit intodotnetprojects:masterfrom
punker76 wants to merge 1 commit intodotnetprojects:masterfrom
Conversation
Fonts.SystemFontFamilies can return multiple entries with the same name, causing ToDictionary to throw an ArgumentException. Use GroupBy to handle duplicates by keeping the first occurrence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TypeInitializationException/ArgumentExceptioninFontResolverwhen the system has duplicate font names (e.g. "bundaysans")ToDictionarywithGroupBy+ToDictionaryto gracefully handle duplicates by keeping the first occurrenceProblem
On systems where
Fonts.SystemFontFamiliesreturns multiple font families with the same name (case-insensitive), theFontResolverconstructor crashes with anArgumentException: An item with the same key has already been added.Since
FontResolveris used in the static constructor ofTextStyle, this causes aTypeInitializationExceptionthat prevents any SVG with text elements from rendering:Solution
Replaced the direct
ToDictionarycall withGroupBy+ToDictionary, which groups fonts by name first and then picks the first entry per group. This avoids the duplicate key exception while keeping the original lookup behavior intact.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: