Merged
Conversation
added 30 commits
August 21, 2025 18:11
…rimary key (there is only one)
added 2 commits
August 27, 2025 15:19
added 14 commits
August 27, 2025 16:47
JaBistDuNarrisch
requested review from
codinghardadmin,
guertel and
lschirmbrand
rjanisch
approved these changes
Aug 28, 2025
Schlupp77
reviewed
Nov 6, 2025
| var index = indexes.Single(); | ||
|
|
||
| Assert.That(index.Unique, Is.True); | ||
| Assert.That(ex.SqlState, Is.EqualTo("23505")); |
| var ex = Assert.Throws<PostgresException>(() => Provider.Insert(tableName, [columnName, columnName2], [100, "Hello"])); | ||
|
|
||
| Assert.That(index.Unique, Is.True); | ||
| Assert.That(ex.SqlState, Is.EqualTo("23505")); |
There was a problem hiding this comment.
Hier wird derselbe wert nochmal verwendet. Keine Magic Strings?
| var index = Provider.GetIndexes(tableName).Single(); | ||
|
|
||
| Assert.That(index.Unique, Is.True); | ||
| Assert.That(sqlException.Number, Is.EqualTo(2601)); |
| var index = Provider.GetIndexes(tableName).Single(); | ||
|
|
||
| Assert.That(index.Unique, Is.True); | ||
| Assert.That(sqlException.Number, Is.EqualTo(2601)); |
| return from DataRow row in tables.Rows select (row["TABLE_NAME"] as string); | ||
| } | ||
|
|
||
| protected void ValidateIndex(string tableName, Index index) |
There was a problem hiding this comment.
Wäre der Name ValidateIndexBeforeAdding() besser?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122
Fixes #123
Fixes #124
Fixes #125
Fixes #126