[Hosting] Do not set activity status on exception#65825
Open
martincostello wants to merge 1 commit intodotnet:mainfrom
Open
[Hosting] Do not set activity status on exception#65825martincostello wants to merge 1 commit intodotnet:mainfrom
martincostello wants to merge 1 commit intodotnet:mainfrom
Conversation
Do not set the status description when an exception occurs as it can be inferred from the HTTP status that will be served to align with the existing behaviour of OpenTelemetry.Instrumentation.AspNetCore. Resolves open-telemetry/opentelemetry-dotnet-contrib#3968.
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @@martincostello. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Hosting’s Activity end-tagging behavior so exceptions no longer set an Activity status description, aligning with existing OpenTelemetry AspNetCore instrumentation behavior while still marking the span as Error and recording error.type.
Changes:
- Stop passing
exception.MessageintoActivity.SetStatus(...)when an exception is present. - Update the corresponding diagnostics test to assert
StatusDescriptionisnullfor exception scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs | Removes exception message from Activity.SetStatus so status description is not set on exceptions. |
| src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs | Adjusts assertion to expect StatusDescription to be null when an exception is reported. |
JamesNK
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not set activity status on exception
Do not set the
Activitystatus description when an exception is thrown.Description
Do not set the status description when an exception occurs as it can be inferred from the HTTP status that will be served to align with the existing behaviour of OpenTelemetry.Instrumentation.AspNetCore (code).
Fixes open-telemetry/opentelemetry-dotnet-contrib#3968