Merged
Conversation
The if/elsif/end block didn't return date as a default, so years where Iyar 5 falls on Wed/Thu/Sun returned nil. The Shabbat branch also returned nil since set_hebrew_date mutates in place. This crashed YOM_HAZIKARON which calls #back on the result. Co-authored-by: Claude <noreply@anthropic.com>
Replace tab indentation with spaces in _hebrew_calendar_elapsed_days and _hebrew_date_to_abs_date to align if/else/end keywords. Co-authored-by: Claude <noreply@anthropic.com>
dorner
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
from_holiday(:YOM_HAATZMAUT)returning nil for years where Iyar 5 needs no day-of-week shift or falls on Shabbat, which also crashedfrom_holiday(:YOM_HAZIKARON)Additional changes
doc/from the gemGemfile.lockfrom the repo