Skip to content
This repository was archived by the owner on Nov 22, 2023. It is now read-only.

Backporting some fixes#19

Open
donniebreve wants to merge 4 commits intomainfrom
update-binding-code
Open

Backporting some fixes#19
donniebreve wants to merge 4 commits intomainfrom
update-binding-code

Conversation

@donniebreve
Copy link
Copy Markdown
Owner

@donniebreve donniebreve commented May 30, 2022

Backporting some fixes and cleanup from @cprovatas recent fork. Thanks for the input.

@donniebreve donniebreve requested a review from jasonmlkang May 30, 2022 22:09
This was referenced May 31, 2022
}
}
// Set the capslock modifier
if (code == KEY_CAPSLOCK)
Copy link
Copy Markdown

@cprovatas cprovatas Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we don't need to handle it in this PR, but it would be nice to update the LED light of the caps lock button if kCGEventFlagMaskAlphaShift is in the modifiers.

Looks like this function manipulate_led might do it

https://web.archive.org/web/20180924040224/http://osxbook.com/book/bonus/chapter10/kbdleds/download/keyboard_leds.c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants