Skip to content

remove(result): return result instead of storing it off#105

Merged
case-fastly merged 1 commit intomainfrom
integralist/deprecate-result
Feb 16, 2026
Merged

remove(result): return result instead of storing it off#105
case-fastly merged 1 commit intomainfrom
integralist/deprecate-result

Conversation

@Integralist
Copy link
Copy Markdown
Contributor

Fixes #70

Summary

Login now returns (Result, error) instead of error, giving callers direct access to the login response. The deprecated LoginResult field and its associated mutex usage have been removed from Conn.

Caller migration

// Before
err := conn.Login(user, pass, "")
code := conn.LoginResult.Code

// After
result, err := conn.Login(user, pass, "")
code := result.Code

Release

- Tag: `git tag -a v0.2.0 -m "Login returns (Result, error); remove deprecated LoginResult field"`
- Push: `git push origin v0.2.0`

@case-fastly
Copy link
Copy Markdown
Contributor

Thank you!

@case-fastly case-fastly merged commit 80d0409 into main Feb 16, 2026
1 check passed
@case-fastly case-fastly deleted the integralist/deprecate-result branch February 16, 2026 16:37
@Integralist
Copy link
Copy Markdown
Contributor Author

@case-fastly did you want me to do the git tag/release? Are you happy with 0.2.0 or would you prefer to keep incrementing the patch 0.1.8 is next iirc

@case-fastly
Copy link
Copy Markdown
Contributor

@case-fastly did you want me to do the git tag/release? Are you happy with 0.2.0 or would you prefer to keep incrementing the patch 0.1.8 is next iirc

Ooh good call, yeah go for it. Thank you!

@Integralist
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is there an adequate replacement for deprecated LoginResult field?

2 participants