Fix SingleMemoryStorageSchedule checkpoint clearing during forward replay#248
Open
sghelichkhani wants to merge 1 commit intodolfin-adjoint:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #211.
During forward replay, the checkpoint clearing logic for
SingleMemoryStorageScheduleusesadjoint_dependenciesfrom the previous timestep to decide whether a checkpoint is safe to discard. Butadjoint_dependenciesis only fully populated during the reverse pass (after PR #210), so at forward replay time it can be incomplete, causing needed checkpoints to be cleared.This replaces the
adjoint_dependenciescheck with a block variable identity check:If
var.output.block_variable is var, the Function still holds the correct value in memory, so the checkpoint copy is redundant. Ifis not var, a later block has taken ownership and will overwrite the Function during replay, so the checkpoint must be kept.Test
Tested against the MFE on issue #211.