Skip to content

Improvements to TMapObjGeneral#90

Open
nstearns96 wants to merge 1 commit intodoldecomp:mainfrom
nstearns96:MapObjGeneral
Open

Improvements to TMapObjGeneral#90
nstearns96 wants to merge 1 commit intodoldecomp:mainfrom
nstearns96:MapObjGeneral

Conversation

@nstearns96
Copy link

Initial implementations:

  • TMapObjGeneral::put
  • TMapObjGeneral::thrown
  • TMapObjGeneral::calcVelocity
  • TMapObjGeneral::bind

Improved matches on:

  • TMapObjGeneral::waitingToAppear
  • TMapObjGeneral::touchGround

Symbols named:

  • TMapObjGeneral::unk4 ->mTimeTilAppear
  • TMapObjGeneral::getUnk4 -> getTimeTilAppear
  • TMapObjGeneral::isUnk104Positive -> isReadyToAppear
  • TLiveFlagBits::LIVE_FLAG_UNK10 -> LIVE_FLAG_NOT_MOVING

Note: This is my first contribution to this project and any decomp project. Any feedback would be appreciated.

@nstearns96
Copy link
Author

I've reverted the naming of TLiveFlagBits::LIVE_FLAG_UNK10, fixed the fake matching in the JGeometry usage, and fix the compilation/formatting.

@encounter
Copy link
Contributor

encounter commented Mar 19, 2026

Report for GMSJ01 (f1ccc3e - 0b648bc)

📈 7 improvements in unmatched items
Unit Item Bytes Before After
mario/MoveBG/MapObjGeneral TMapObjGeneral::bind() +633 0.62% 99.65%
mario/MoveBG/MapObjGeneral TMapObjGeneral::thrown() +430 0.83% 89.80%
mario/MoveBG/MapObjGeneral TMapObjGeneral::calcVelocity() +415 0.95% 99.95%
mario/MoveBG/MapObjGeneral TMapObjGeneral::put() +268 1.47% 99.84%
mario/MoveBG/MapObjGeneral TMapObjGeneral::waitingToAppear() +80 76.31% 98.99%
mario/MoveBG/MapObjGeneral TMapObjGeneral::touchGround(JGeometry::TVec3<float>*) +17 96.31% 99.84%
mario/MoveBG/MapObjGeneral .sdata2 +11 75.00% 95.83%

Initial implementations:
- TMapObjGeneral::put
- TMapObjGeneral::thrown
- TMapObjGeneral::calcVelocity
- TMapObjGeneral::bind

Improved matches on:
- TMapObjGeneral::waitingToAppear
- TMapObjGeneral::touchGround

Symbols named:
    TMapObjGeneral::unk4 ->mTimeTilAppear
    TMapObjGeneral::getUnk4 -> getTimeTilAppear
    TMapObjGeneral::isUnk104Positive -> isWaitingToAppear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants