Hide /q from dialogs and sort all commands by label#2200
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 20, 2026
Merged
Conversation
- Add Hidden field to commands.Item for slash-only aliases - Mark /q as hidden so only /exit and /quit appear in UI - Filter hidden commands centrally in BuildCommandCategories - Sort all command categories by label uniformly - Sort completion items across categories into a single flat list Fixes docker#2194 Assisted-By: docker-agent
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR cleanly implements the hidden command feature and sorting improvements:
✅ Correctly adds Hidden field to filter /q from UI while keeping it functional
✅ Centralized filtering in BuildCommandCategories with visibleOnly helper
✅ Uniform sorting applied to all command categories by label
✅ Flat sorted completion list across all categories
✅ No bugs found - closure variable capture is correctly implemented
The code follows Go best practices and the changes are well-structured.
derekmisler
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiddenfield tocommands.Itemfor slash-only aliases/qas hidden so only/exitand/quitappear in UIBuildCommandCategoriesFixes #2194