feat(ui): config option to override buffer switching logic

[mrcjkb]

This is my suggestion to fix #287.

[dmtrKovalenko]

I'd probably have a suggestion to have a function override here we might want to extend the logic with more heuristics there for example if the buffer is modifiable or not

[mrcjkb]

for example if the buffer is modifiable or not

I removed that check because it seemed too strict to me (terminal buffers aren't modifiable, for instance).

[dmtrKovalenko]

Please do not remove any checks. There are a plenty of buffers of special file types that we should never replace

this is simply the worst experience when your file opens in the sidebar which is always happens to snacks nvim for example

[mrcjkb]

Please do not remove any checks. There are a plenty of buffers of special file types that we should never replace

this is simply the worst experience when your file opens in the sidebar which is always happens to snacks nvim for example

Do you have an example?
I don't think I use any plugins that create a "sidebar", which would explain why I haven't experienced any issues without the modifiable check.

[dmtrKovalenko]

https://github.com/hedyhli/outline.nvim I use this one personally

[mrcjkb]

Hmm, how about keeping the behaviour as is and adding a config option to disable it altogether? Or a config option to override the behaviour with a function?
I don't use sidebar or file tree plugins, so for me, having my selection replace a seemingly arbitrary buffer isn't great.

[dmtrKovalenko]

Yeah that’s what I’m saying you can make a function that overrides the existing one without changing the behavior

[mrcjkb]

Done. I moved the logic for finding a suitable window to the config module. That might not be the best place - perhaps you'd want a hooks module or something.

[dmtrKovalenko]

thx!

[dmtrKovalenko]

I don't know if this is actually a hook

[mrcjkb]

Shall we call it pre_select_callback or on_pre_select?

[dmtrKovalenko]

I mean it's unclear that this hook should actually change the window, maybe we should just override the whole open_file callback that is doing all the window picking and :e call

this would be more flixble probably

[dmtrKovalenko]

or the other option is to make this callback return the window_id and we then opening the file in this window