Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds new Lua API helpers for retrieving “things” located on a specific subtile or slab, plus Lua-side convenience wrappers for common classes (creatures/objects).
Changes:
- Added C-side Lua globals
GetThingsOnSubtileandGetThingsOnSlab. - Added Lua manager helpers
GetCreaturesOnTile/SubtileandGetObjectsOnTile/Subtile. - Registered new manager and updated Lua bindings metadata for the new functions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lua_api.c | Implements and registers new Lua-exposed queries for things on a subtile/slab. |
| config/fxdata/lua/managers/ThingManager.lua | Adds object-focused convenience wrappers built on the new C APIs. |
| config/fxdata/lua/managers/CreatureManager.lua | Adds creature-focused convenience wrappers built on the new C APIs. |
| config/fxdata/lua/init.lua | Loads the new ThingManager during Lua API initialization. |
| config/fxdata/lua/bindings/things.lua | Declares Lua binding stubs/docs for the new global functions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…perfx into lua_things_on_tile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a selection of functions to fetch things on a specific slab or subtile
GetCreaturesOnTile
GetObjectsOnSlab
GetObjectsOnSubtile
GetThingsOnSubtile