Coloured info/objective/warning messages#4624
Open
Spatulade wants to merge 28 commits intodkfans:masterfrom
Open
Coloured info/objective/warning messages#4624Spatulade wants to merge 28 commits intodkfans:masterfrom
Spatulade wants to merge 28 commits intodkfans:masterfrom
Conversation
set up objectives to be unique per colour for now, not sure a better way to do it. Need to set up OBJECTIVE/INFORMATION (and make WARNING which should just be similar to INFORMATION), extra argument should specify colour and link to sprite and, for objective, EvKind_Objective[Colour].
It feels gross doing it this way, hopefully we don't actually have to do this and there's a more compact way.
Set up types and colours better (hopefully). Aim is to add "icon" to Event struct and update this, then use this later on when setting message sprite.
oh god do i have to add the extra argument to everything
if commands only accept three inputs, we split location and coords commands to free up the slot for the colour. I don't think I understand how the commands work enough to know if this is even right though
…s, added BONUS_INFORMATION script commands with setup I've set up the four commands for bonus information (coloured info icons), their corresponding commands (I had to split location and coords so that param3 could be colour), and set events for them. DISPLAY_BONUS_INFORMATION set_general_bonus_information_at_location EvKind_BonusInformation DISPLAY_BONUS_INFORMATION_WITH_POS set_general_bonus_information_at_coords EvKind_BonusInformation QUICK_BONUS_INFORMATION set_quick_bonus_information_at_location EvKind_QuickBonusInformation QUICK_BONUS_INFORMATION_WITH_POS set_quick_bonus_information_at_coords EvKind_QuickBonusInformation I don't think the commands have actually grabbed the icon properly so I need help figuring out how to make them point to the right place correctly. I also think this means that when a new bonus information tab is made with a different colour, it will update all existing ones as well which is not ideal. But I don't know for sure. I did wonder if there was a way to directly overwrite the bttn_sprite in event_button_info, but I don't know if that's a worse idea. I think this is getting there at least!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan is to add different colours for INFORMATION/OBJECTIVE commands (and add in WARNING command, basically same as INFORMATION but using a ! instead of an i), and add an additional optional argument specifying colour in {BLUE,GREEN,RED,YELLOW,PURPLE,WHITE,GREY,ORANGE,BROWN}. I also thought about adding another argument to OBJECTIVE to allow for different discrete objectives tracked separately (I currently split the event out by colour but I'd prefer to have Objective2-8 and the colour to be decided using the colour argument, so you can have multiple with the same colour and allow the same objective to change colour etc)
Graphics in dkfans/FXGraphics#113