Migrate from Trillium [part 1]: divviup-client and CLI to reqwest#2193
Open
Migrate from Trillium [part 1]: divviup-client and CLI to reqwest#2193
Conversation
Replace trillium-client and trillium-http with reqwest in the divviup-client SDK, and remove trillium-rustls/trillium-tokio from the CLI. > [!note] > This is a breaking change to the divviup-client public API. - DivviupClient now wraps reqwest::Client instead of trillium_client::Client - Re-exports http and reqwest crates instead of trillium types - Error enum uses reqwest::Error instead of trillium error types - CLI uses #[tokio::main] and reqwest::Client::builder() directly - Client tests spawn a real TCP server instead of using trillium_testing::connector() - Bump workspace version to 0.5.0-pre.1 for the dep break
# Conflicts: # Cargo.lock # Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace trillium-client and trillium-http with reqwest in the divviup-client SDK, and remove trillium-rustls/trillium-tokio from the CLI.
Note
This is a breaking change to the divviup-client public API.