Replace unwrap with error propagation for JanusTime conversion#2191
Open
Replace unwrap with error propagation for JanusTime conversion#2191
Conversation
TaskResponse::task_expiration() panicked on u64-to-i64 overflow when an aggregator returned a task_expiration exceeding i64::MAX. Humorously, we already returned time::error::ComponentRange, so just changing that to Error lets us use `?`, and since we already have `From` impls, this just works.
tgeoghegan
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskResponse::task_expiration() panicked on u64-to-i64 overflow when an aggregator returned a task_expiration exceeding i64::MAX.
Humorously, we already returned time::error::ComponentRange, so just changing that to Error lets us use
?, and since we already haveFromimpls, this just works.