Make Message a regular class instead of a Struct#386
Open
moberegger wants to merge 1 commit intodiscourse:mainfrom
Open
Make Message a regular class instead of a Struct#386moberegger wants to merge 1 commit intodiscourse:mainfrom
Message a regular class instead of a Struct#386moberegger wants to merge 1 commit intodiscourse:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a weird one that I hope isn't too contentious. The initialization of
Messagewas coming up as a CPU hotspot in our production profiles. I didn't think anything of it and figured it was just because it was called so often. Then I noticed it was aStructand got curious.I compared the initialization between a regular class and a
Struct, and there is a noticeable improvement when using a plain old Ruby class - at least on Ruby 4 with yjit on.This PR refactors
Messageto a regular Ruby class. Included is an implementation of==for use by tests.