Open
Conversation
dimikot
requested changes
May 28, 2018
|
|
||
| # Set the number of changes that will trigger an rsync from the config file | ||
| $MIN_CHANGES_FOR_RSYNC = cfg("rsync_threshold"); | ||
| print "mainloop MIN_CHANGES_FOR_RSYNC: $MIN_CHANGES_FOR_RSYNC\n"; |
| } | ||
|
|
||
| # Set the number of changes that will trigger an rsync from the config file | ||
| $MIN_CHANGES_FOR_RSYNC = cfg("rsync_threshold"); |
Owner
There was a problem hiding this comment.
this should have a default value, or realsync will break for people who don't have this option in their config yet?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the user the ability to configure the threshold that it uses rsync for.