fix: Cholesky::new returns None non-positive-definite complex matrices#1592
Open
DiogoRibeiro7 wants to merge 3 commits intodimforge:mainfrom
Open
fix: Cholesky::new returns None non-positive-definite complex matrices#1592DiogoRibeiro7 wants to merge 3 commits intodimforge:mainfrom
DiogoRibeiro7 wants to merge 3 commits intodimforge:mainfrom
Conversation
* Add known-failing unit test case for SymmetricEigen * Fix eigenvector calculation for subdim=2 case in SymmetricEigen
…rices For complex types, always succeeds (every complex number has a square root), so non-PD matrices were silently producing garbage results. Fix by calling on the real part of each diagonal pivot instead — matching the behaviour already correct for . Fixes dimforge#1536
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For complex types, always succeeds (every complex number has a square root), so non-PD matrices were silently producing garbage results. Fix by calling on the real part of each diagonal pivot instead — matching the behaviour already correct for .
Fixes #1536