Add react-native section to package.json#528
Closed
dmitrizagidulin wants to merge 5 commits intodigitalbazaar:mainfrom
Closed
Add react-native section to package.json#528dmitrizagidulin wants to merge 5 commits intodigitalbazaar:mainfrom
dmitrizagidulin wants to merge 5 commits intodigitalbazaar:mainfrom
Conversation
dmitrizagidulin
force-pushed
the
react-native
branch
from
0e3187a to
190b7db
Compare
dlongley
requested changes
Aug 11, 2023
dmitrizagidulin
force-pushed
the
react-native
branch
from
a532131 to
bd780da
Compare
3 tasks
dlongley
approved these changes
Jan 27, 2024
Member
dlongley
left a comment
dlongley
left a comment
There was a problem hiding this comment.
Thanks!
@davidlehn, please take a look here and see if it works with our approach here to better enabling the TypeScript community to use this package w/o adding maintenance burden (that we won't be able to meet) as this is a JavaScript-only package.
| @@ -0,0 +1 @@ | |||
| declare module 'jsonld'; | |||
Member
There was a problem hiding this comment.
If this is as complicated as this file gets, it seems fine to me (shouldn't really be any maintenance).
Contributor
Author
|
@dlongley @davidlehn Any chance of merging in this PR, since it's got approval? |
Member
|
Member
|
Fixed in v9.0.0 via #572. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add React Native support, and instructions in the README.
See also: