Conversation
| }); | ||
| const verificationKeyPair = await Ed25519VerificationKey2020.generate(); | ||
| const {didDocument, keyPairs} = | ||
| await didKeyDriver.fromKeyPair({verificationKeyPair}); |
There was a problem hiding this comment.
Hmm, we might want to just remove this test. keyPairs would need to be updated for this to work properly. Someone might also copy this example and it isn't correct now. The keyPairs would need to be updated in some way to enable the use of signers.
There was a problem hiding this comment.
Right, that's what this issue is about: #26
There was a problem hiding this comment.
In preparation for a fix somehow somewhere here, I think the appropriate thing is to demonstrate how to properly initialize the client. And therefore proper keys should be passed in etc. We now recognize that successfully calling the constructor does not produce a fully operational client instance.
jameseaster
force-pushed
the
update-did-method-key
branch
from
ccbe9d1 to
1b988c8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage 63.92% 63.92%
=======================================
Files 3 3
Lines 621 621
=======================================
Hits 397 397
Misses 224 224 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
4 participants
Resolves - updates did-method-key dependency to latest version 5.2.0
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
How has this been tested?
Screenshots: n/a