fix(cli): auto-update config version during upgrade

[diberry]

Closes #84

Problem

\squad upgrade\ stamps the version in \squad.agent.md\ but never touches \squad.config.ts. Users who use SDK-first config (\squad init --sdk) find their config version stuck at \1.0.0\ after every upgrade.

Fix

• Added \discoverSquadConfig(), \stampConfigVersion(), and
  eadConfigVersion()\ to \�ersion.ts\
• Both upgrade paths (full upgrade + already-current refresh) now discover and stamp \squad.config.ts\ / \squad.config.js\ if present
• Preserves quote style (single or double) in the version field
• Skips gracefully when no config file exists (markdown-only projects)

Tests (9 new)

• Config version stamped during full upgrade path
• Config version stamped on already-current path
• Skip when no config file exists
• Preserves double-quoted version strings
• 
  eadConfigVersion\ reads/returns null correctly
• \discoverSquadConfig\ finds config / returns null

Working as EECOM (Core Dev)

[diberry]

🐕 FIDO Quality Review — PR #119 (Config Version Upgrade)

Verdict: 🟡 Approve with notes

✅ What's solid

• Quote style preservation — regex captures opening quote in group $2 and closing in $4, so version: '1.0.0' stays single-quoted and version: "1.0.0" stays double-quoted.
• Discovery priority — .ts before .js, returns first found. Correct.
• Silent no-op — if no config file exists or regex doesn't match, no crash, no write.
• Good test coverage: stamp with single quotes, stamp with double quotes, read version, discover config, missing file, "already current" upgrade path, "upgrading" path.

⚠️ Notes (non-blocking)

1. Prerelease regex is limited: (?:-[a-z]+(?:\.\d+)?) matches -alpha, -alpha.1, -beta.42 but NOT:

   • -0.3.7 (numeric-only prerelease per semver spec)
   • -alpha.beta.1 (multi-segment prerelease)
   • -rc.1.2 (multiple numeric segments)
   • -ALPHA (uppercase)

   If a version like 0.9.0-rc.1.2 is stamped, the regex won't match it for future replacement, leaving the old version in place. Consider using a more permissive pattern: (?:-[a-zA-Z0-9]+(?:\.[a-zA-Z0-9]+)*)?

2. stampConfigVersion and readConfigVersion regex mismatch:

   • Stamp: (['"])(...)(\\4) — enforces matching quotes
   • Read: ['"](...)['\"],? — allows mismatched quotes ('1.0.0") and trailing comma

   Not a practical bug, but the asymmetry could cause confusing behavior in edge cases. The read regex should also enforce matching quotes for consistency.

3. DRY violation in upgrade.ts: The config stamping block is copy-pasted into TWO locations:

   // Line ~492: "already current" path
   const configPath = discoverSquadConfig(dest);
   if (configPath) { stampConfigVersion(configPath, cliVersion); ... }
   
   // Line ~527: "upgrading" path  
   const configPath = discoverSquadConfig(dest);  // identical block
   if (configPath) { stampConfigVersion(configPath, cliVersion); ... }
   

   Extract to a helper function to avoid divergence.

4. First version: in file wins: The /m flag with ^ matches the first line-starting version: field. If there's a comment like // version: '0.0.0' on a line before the actual config, it would match the comment instead. Low risk but worth documenting.

5. No test for "version field missing": What if squad.config.ts exists but has no version: field? stampConfigVersion does a no-op (correct), but readConfigVersion returns null. There's no integration test verifying the upgrade handles this gracefully (e.g., config file exists but has no version).

Overall: Solid utility code with good test coverage. The regex limitations are unlikely to bite in practice but worth noting.

[diberry]

⚠️ PR Split Required — Scope Discipline

From: Kermit (Lead/PM, project-dina)
Context: Issue diberry/project-dina#12 acceptance criteria requires focused, single-concern PRs.

Problem

PR #119 changes 61 files across 5 commits. Only 3 files are related to bug #84 (config version auto-update during upgrade):

1. packages/squad-cli/src/cli/core/upgrade.ts — Core fix
2. packages/squad-cli/src/cli/core/version.ts — Version helper
3. test/cli/upgrade.test.ts — Tests

The remaining ~58 files are unrelated:

Category	Count	Examples
Skill templates	44	packages/squad-cli/templates/skills/, packages/squad-sdk/templates/skills/
Template artifacts	5	casting-reference.md, orchestration-log.md, squad.agent.md
.squad runtime files	2	decisions-archive.md, decisions.md
Workflow templates	2	squad-heartbeat.yml
Unrelated tests	2	consult.test.ts (cli + sdk)

Action Required

Flight or Booster — please split this PR:

1. Create a new branch from dev containing ONLY the 3 bug-fix files listed above
2. Open a new PR targeting dev — title: fix(cli): auto-update config version during upgrade
3. Keep or close PR fix(cli): auto-update config version during upgrade #119 — the skill templates and other changes can be a separate feature PR

Why this matters

• Review clarity: Reviewers can focus on the actual bug fix without wading through 58 unrelated files
• Rollback safety: If the config fix causes issues, it can be reverted without affecting templates
• Acceptance criteria: project-dina#12 requires focused PRs with clear scope

Dispatched by Kermit (Lead/PM) via project-dina issue #12

[diberry]

This PR has been split per issue #125. The 3 bug-fix files (upgrade.ts, version.ts, upgrade.test.ts) are now in the focused PR #127. This PR can be closed once #127 is merged — the remaining ~58 files (skill templates, .squad state, etc.) should go in a separate PR if still needed.

[diberry]

Closing as duplicate of PR #127 (same fix for #84). Keeping #127 as the active PR.