Vaidate pic_size_in_map_units_minus1, avoid unbounded allocation#117
Open
Vaidate pic_size_in_map_units_minus1, avoid unbounded allocation#117
Conversation
|
| Branch | validate-pic-size-in-map-units |
| Testbed | Linux |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
- RAM Hits (hits)
- L1 Hits (hits)
- L2 Hits (hits)
- Instructions (instructions)
- Total read+write (reads/writes)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles x 1e6 (Result Δ%) | Upper Boundary estimated cycles x 1e6 (Limit %) | Instructions | instructions x 1e6 | L1 Hits | hits x 1e6 | L2 Hits | hits x 1e3 | RAM Hits | hits x 1e3 | Total read+write | reads/writes x 1e6 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ci_bench::ci::reader read:setup_video("big_buck_bunny_1080p_24fps_h264.h264"... | 📈 view plot 🚷 view threshold | 16.67 x 1e6(-0.03%)Baseline: 16.67 x 1e6 | 16.74 x 1e6 (99.58%) | 📈 view plot | 8.20 x 1e6 | 📈 view plot | 10.78 x 1e6 | 📈 view plot | 18.16 x 1e3 | 📈 view plot | 165.62 x 1e3 | 📈 view plot | 10.96 x 1e6 |
574bb74 to
c858e53
Compare
This requires that read_group_ids() gains access to the SPS, which holds the pic_size_in_map_units we need to compare against.
c858e53 to
bc7aebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires that
read_group_ids()gains access to the SPS, which holds thepic_size_in_map_unitswe need to compare against.