Skip to content

Vaidate pic_size_in_map_units_minus1, avoid unbounded allocation#117

Open
dholroyd wants to merge 1 commit intomasterfrom
validate-pic-size-in-map-units
Open

Vaidate pic_size_in_map_units_minus1, avoid unbounded allocation#117
dholroyd wants to merge 1 commit intomasterfrom
validate-pic-size-in-map-units

Conversation

@dholroyd
Copy link
Owner

@dholroyd dholroyd commented Mar 7, 2026

This requires that read_group_ids() gains access to the SPS, which holds the pic_size_in_map_units we need to compare against.

@github-actions
Copy link

github-actions bot commented Mar 7, 2026

🐰 Bencher Report

Branchvalidate-pic-size-in-map-units
TestbedLinux

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles x 1e6
(Result Δ%)
Upper Boundary
estimated cycles x 1e6
(Limit %)
Instructionsinstructions x 1e6L1 Hitshits x 1e6L2 Hitshits x 1e3RAM Hitshits x 1e3Total read+writereads/writes x 1e6
ci_bench::ci::reader read:setup_video("big_buck_bunny_1080p_24fps_h264.h264"...📈 view plot
🚷 view threshold
16.67 x 1e6
(-0.03%)Baseline: 16.67 x 1e6
16.74 x 1e6
(99.58%)
📈 view plot
⚠️ NO THRESHOLD
8.20 x 1e6📈 view plot
⚠️ NO THRESHOLD
10.78 x 1e6📈 view plot
⚠️ NO THRESHOLD
18.16 x 1e3📈 view plot
⚠️ NO THRESHOLD
165.62 x 1e3📈 view plot
⚠️ NO THRESHOLD
10.96 x 1e6
🐰 View full continuous benchmarking report in Bencher

@dholroyd dholroyd force-pushed the validate-pic-size-in-map-units branch from 574bb74 to c858e53 Compare March 7, 2026 01:08
This requires that read_group_ids() gains access to the SPS, which holds
the pic_size_in_map_units we need to compare against.
@dholroyd dholroyd force-pushed the validate-pic-size-in-map-units branch from c858e53 to bc7aebd Compare March 7, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant