Conversation
Picking a 12 month old rust version is a bit arbitrary. My assumption is that this will avoid too much rust-version churn for dependant projects.
|
Bencher Report| Branch | msrv-bump |
| Testbed | Linux |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
- Instructions (instructions)
- L2 Hits (hits)
- L1 Hits (hits)
- RAM Hits (hits)
- Total read+write (reads/writes)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles x 1e6 (Result Δ%) | Upper Boundary estimated cycles x 1e6 (Limit %) | Instructions | instructions x 1e6 | L1 Hits | hits x 1e6 | L2 Hits | hits x 1e3 | RAM Hits | hits x 1e3 | Total read+write | reads/writes x 1e6 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ci_bench::ci::reader read:setup_video("big_buck_bunny_1080p_24fps_h264.h264"... | 📈 view plot 🚷 view threshold | 16.72 x 1e6(+0.26%)Baseline: 16.67 x 1e6 | 16.74 x 1e6 (99.87%) | 📈 view plot | 8.25 x 1e6 | 📈 view plot | 10.83 x 1e6 | 📈 view plot | 18.21 x 1e3 | 📈 view plot | 165.62 x 1e3 | 📈 view plot | 11.01 x 1e6 |
Collaborator
|
No strong feelings here. I tend to be pretty haphazard in my own projects, bumping it when needed to keep deps up-to-date or for a particular feature. There's no feature I need in h264-reader. let-chains are certainly convenient, and they're more than a year old now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking a 12 month old rust version is a bit arbitrary. My assumption is that this will reduce rust-version churn for dependant projects.
@scottlamb since you mentioned MSRV policy in #111 ... N - 12 good for you?