fix(app-platform): upgrade platform tools to use vite and react 18#402
Open
KaiVandivier wants to merge 11 commits intomasterfrom
Open
fix(app-platform): upgrade platform tools to use vite and react 18#402KaiVandivier wants to merge 11 commits intomasterfrom
KaiVandivier wants to merge 11 commits intomasterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm running into issues with styled-jsx in this one. The app seems to work with v5 in the app and v4 in the app shell; resolving to either v5 or v4 for both doesn't seem to work. If it's okay to use two different versions, then I can disabled the 'singleton' check that blocks the build
DHIS2-18795
Mostly automated by dhis2/app-platform#887.