fix: Return list when no indexes specified for excludeIndexes

src/main/java/org/hisp/dhis/model/analytics/AnalyticsData.java

@@ -45,10 +45,12 @@
 import java.util.stream.Collectors;
 import lombok.Getter;
 import lombok.Setter;
+import lombok.ToString;
 import org.apache.commons.lang3.StringUtils;
 
 @Getter
 @Setter
+@ToString
 public class AnalyticsData implements Serializable {
   /** Analytics column headers. */
   @JsonProperty private List<AnalyticsHeader> headers;

src/main/java/org/hisp/dhis/util/CollectionUtils.java

@@ -291,8 +291,8 @@ public static <T> Set<T> filterToSet(Collection<T> collection, Predicate<T> pred
    * @return a new list of the items in the given list which are not at the given indexes.
    */
   public static <T> List<T> excludeIndexes(List<T> list, Set<Integer> indexes) {
-    if (empty(list) || empty(indexes)) {
-      return List.of();
+    if (empty(indexes)) {
+      return list;
     }
 
     return IntStream.range(0, list.size())

src/test/java/org/hisp/dhis/util/CollectionUtilsTest.java

@@ -144,8 +144,10 @@ void testExcludeIndexes() {
     assertContainsExactly(excludeIndexes(list, Set.of(1, 3, 4)), pA, pC);
     assertContainsExactly(excludeIndexes(list, Set.of(2, 4)), pA, pB, pD);
     assertEmpty(excludeIndexes(list, Set.of(0, 1, 2, 3, 4)));
-    assertEmpty(excludeIndexes(null, Set.of(0, 2)));
-    assertEmpty(excludeIndexes(list, null));
+    assertEquals(list, excludeIndexes(list, Set.of()));
+    assertEquals(list, excludeIndexes(list, null));
+    assertEmpty(excludeIndexes(List.of(), Set.of(0, 2)));
+    assertEmpty(excludeIndexes(List.of(), Set.of()));
   }
 
   @Test