Draft
Conversation
mraszyk
commented
Mar 16, 2026
Comment on lines
+1593
to
+1600
| pub fn release_reserved_response_slot_for_testing(&mut self, response: &Response) { | ||
| let (input_queue, _output_queue) = self | ||
| .canister_queues | ||
| .get_mut(&response.respondent) | ||
| .expect("No matching queue."); | ||
| Arc::make_mut(input_queue).release_reserved_response_slot(); | ||
| self.queue_stats.on_push_timeout_response(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Does this look good to you, @alin-at-dfinity ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs the following changes:
ExecutionTestandSchedulerTestunit test frameworks;ExecutionTest::execute_responseto release the response slot;SystemState::release_reserved_response_slot_for_testingandCanisterQueues::release_reserved_response_slot_for_testingto release a response slot in tests (see previous point);SchedulerTestso that canister snapshots have non-zero size and asserts about their memory usage are meaningful;(The motivation for this PR are potential bugs from previous work that might not be caught reliably by tests.)