perf(crypto): CRP-2907 Improve performance of Ed25519 batch verification#9363
Draft
perf(crypto): CRP-2907 Improve performance of Ed25519 batch verification#9363
Conversation
Previously the implementation took a random seed from the vault but this imposed an overhead of 50 to 100 microseconds for each batch verification. Instead add a new RNG that can be used to generate batch verification nonces without having to perform a vault RPC. Compared to performance on master, the cost of batch verification is reduced by about 20%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the implementation took a random seed from the vault but this imposed an overhead of 50 to 100 microseconds for each batch verification. Instead add a new RNG that can be used to generate batch verification nonces without having to perform a vault RPC. Compared to performance on master, the cost of batch verification is reduced by about 20%.