fix: [DSM-106] Nest subnet message scope within inner round scope#9360
Open
alin-at-dfinity wants to merge 2 commits intomasterfrom
Open
fix: [DSM-106] Nest subnet message scope within inner round scope#9360alin-at-dfinity wants to merge 2 commits intomasterfrom
alin-at-dfinity wants to merge 2 commits intomasterfrom
Conversation
Subnet messages are executed in the inner_round() loop, so their MeasurementScope should be nested within the `round_inner` scope, not directly in the `round` root scope.
alin-at-dfinity
commented
Mar 13, 2026
| &self.metrics.round_subnet_queue, | ||
| root_measurement_scope, | ||
| &self.metrics.round_inner_subnet_queue, | ||
| &measurement_scope, |
Contributor
Author
There was a problem hiding this comment.
This one line is the actual change, everything else is renaming and fixing asserts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subnet messages are executed in the
inner_round()loop, so theirMeasurementScopeshould be nested within theround_innerscope, not directly in theroundroot scope. (The metrics themselves are already namedexecution_round_inner_phase_<xyz>, but the nesting is wrong.)