fix(node-rewards-canister): Fixes sync task not being rescheduled due to possible panic in closure#9352
Open
pietrodimarco-dfinity wants to merge 5 commits intomasterfrom
Open
fix(node-rewards-canister): Fixes sync task not being rescheduled due to possible panic in closure#9352pietrodimarco-dfinity wants to merge 5 commits intomasterfrom
pietrodimarco-dfinity wants to merge 5 commits intomasterfrom
Conversation
pietrodimarco-dfinity
changed the title
pietrodimarco-dfinity
changed the title
NikolaMilosa
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a recovery timer mechanism to ensure tasks are rescheduled after a possible panic in the execution of the task.
This is done scheduling first a timer which reschedules the task itself after sometime (15 min). If the task execution is successful the first timer will be cancelled and the task rescheduled after chosen delay.
This fixes https://dfinity.atlassian.net/browse/SECFIND-2110