Skip to content

feat: [DSM-98] Engine deletion#9031

Open
michael-weigelt wants to merge 41 commits intomasterfrom
mwe/subnet_deletion_test
Open

feat: [DSM-98] Engine deletion#9031
michael-weigelt wants to merge 41 commits intomasterfrom
mwe/subnet_deletion_test

Conversation

@michael-weigelt
Copy link
Contributor

@michael-weigelt michael-weigelt commented Feb 24, 2026

This PR introduces subnet deletion, but restricts the feature to CloudEngines.

For the registry, deleting a subnet means to:

  • Remove its subnet ID from the key subnet_list.
  • Remove its subnet record.
  • Remove all routing table shards that its subnet ID maps to.
  • Remove the catch up package.
  • Remove the subnet public key.

Consumers of subnet_list, the subnet record and the routing table assume live subnets, so the existing interfaces remain semantically unchanged.
Consumers that must take deleted subnets into account do so via old registry versions. One such consumer will be the orchestrator, in a follow-up PR.

@michael-weigelt michael-weigelt changed the title Mwe/subnet deletion test feat: [DSM-98] Engine deletion Mar 10, 2026
@github-actions github-actions bot added the feat label Mar 10, 2026
Copy link
Contributor

@alin-at-dfinity alin-at-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm not being asked to review this, just one random question. (o:

@michael-weigelt michael-weigelt marked this pull request as ready for review March 17, 2026 12:59
@michael-weigelt michael-weigelt requested review from a team as code owners March 17, 2026 12:59
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@michael-weigelt michael-weigelt dismissed github-actions[bot]’s stale review March 17, 2026 13:25

Updated unreleased_changelog.md

No breaking changes

No data migration needed

Security review not needed because the feature is limited to CloudEngines. We'll request an in-depth review before the feature is opened to any subnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants