Skip to content

Test PR/ Do not merge #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piyush140104 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Test PR/ Do not merge #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3fa844
removed depreciated dimensionsString block
piyush140104 Mar 23, 2026
ce38ad4
test: remove level field to trigger validation error
piyush140104 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/assets/YAML/default/BuildAndDeployment/Build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Build and Deployment:
time: 2
resources: 2
usefulness: 2
level: 2
# level: 2 (removed to test exit code bug)
implementation:
- $ref: src/assets/YAML/default/implementations.yaml#/implementations/ci-cd-tools
- $ref: src/assets/YAML/default/implementations.yaml#/implementations/container-technology
Expand Down
10 changes: 0 additions & 10 deletions yaml-generation/generateDimensions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,16 +163,6 @@
}


// Post-process to add activity name as comment for `dependsOn`
$dimensionsString = yaml_emit($dimensionsAggregated);
preg_match_all('/\{!([0-9a-z-]{30,})!\}/', $dimensionsString, $matches);
$uuids = array_unique($matches[1]);
foreach ($uuids as $uuid) {
$name = getActivityNameByUuid($uuid, $dimensionsAggregated);
// echo "Adding dependsOn-comment for $uuid: $name\n";
$dimensionsString = str_replace("'{!$uuid!}'", "$uuid # $name", $dimensionsString);
}

// Store generated data with meta document first
$metaDocument = array(
'meta' => array(
Expand Down