Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
✅ 테스트 결과 for PRBuild: success 🧪 테스트 실행 with Gradle |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 183 out of 183 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public enum RealtimeSortField { | ||
| DATE_AUCTION_EXPIRE("dateAuctionExpire", "경매 만료 일시"), | ||
| DATE_AUCTION_REGISTER("dateRegister", "등록 일시"), | ||
| DATE_AUCTION_REGISTER("dateAuctionRegister", "등록 일시"), |
There was a problem hiding this comment.
The field name was changed from "dateRegister" to "dateAuctionRegister", but the corresponding JPA entity field in AuctionRealtimeItem is dateRegister (line 38 of AuctionRealtimeItem.java). This mismatch will cause a runtime error when sorting by registration date, since Spring Data/QueryDSL won't be able to resolve dateAuctionRegister as a valid property. The field name should remain "dateRegister" to match the entity, or the entity field should be renamed accordingly.
| List<MetalwareSearchRequest> metalwareSearchRequests) { | ||
|
|
||
| public AuctionRealtimeSearchRequest { | ||
| if (isExactItemName == null) { | ||
| isExactItemName = true; | ||
| } |
There was a problem hiding this comment.
The @Schema annotation on isExactItemName declares defaultValue = "false", but the compact constructor now sets the default to true when null. This is inconsistent and will confuse API consumers who read the documentation—they'll expect false as the default, but the actual behavior defaults to exact matching (true). Either update the @Schema(defaultValue = ...) annotation to "true" or change the compact constructor default to false.
|
|
||
| public AuctionHistorySearchRequest { | ||
| if (isExactItemName == null) { | ||
| isExactItemName = true; |
There was a problem hiding this comment.
Same inconsistency as in AuctionRealtimeSearchRequest: the @Schema annotation on isExactItemName declares defaultValue = "false", but the compact constructor now sets the default to true when null. This is a breaking behavioral change (previously, Boolean.TRUE.equals(null) evaluated to false, matching the documented default). Either update the @Schema(defaultValue = ...) to "true", or change the default to false.
| isExactItemName = true; | |
| isExactItemName = false; |
📋 상세 설명
캐시 키 일관성 문제 수정
Redis 역직렬화 개선 및 캐시 워밍업 서비스 분리
Docker 및 Redis 설정 업데이트
📊 체크리스트
이슈 미등록