Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
Pull Request UBI 10 images published ✨ Base Image: quay.io/devfile/base-developer-image:ubi10-pr-240 |
1 similar comment
|
Pull Request UBI 10 images published ✨ Base Image: quay.io/devfile/base-developer-image:ubi10-pr-240 |
|
Pull Request images published ✨ |
1 similar comment
|
Pull Request images published ✨ |
dkwon17
reviewed
Oct 27, 2025
| is_cert=false | ||
| echo "$line" >> ${tmp_file} | ||
| keytool -import -trustcacerts -cacerts -storepass "$KEYSTORE_PASSWORD" -noprompt -alias "${bundle_name}_${cert_index}" -file $tmp_file | ||
| certs_imported=$((certs_imported+1)) |
Collaborator
There was a problem hiding this comment.
Can we check the keytool command for an error and increment certs_imported only if there is no error?
Collaborator
|
It's working as expected: 
|
dkwon17
approved these changes
Oct 28, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dkwon17, tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Pull Request UBI 10 images published ✨ Base Image: quay.io/devfile/base-developer-image:ubi10-pr-240 |
|
Pull Request images published ✨ |
isuftin
added a commit
to isuftin/developer-images
that referenced
this pull request
Dec 12, 2025
feat: Use latest upstream UBI9 image, update kubedock and gh-cli Signed-off-by: Ivan Suftin <isuftin@usgs.gov> feat: Update /etc/sub*id files to support nested containers (devfile#232) * feat: Update /etc/sub*id files in order to run podman command in a user namespace Signed-off-by: Anatolii Bazko <abazko@redhat.com> feat: Use latest upstream UBI9 image, update kubedock and gh-cli (devfile#235) Signed-off-by: Ivan Suftin <isuftin@usgs.gov> Add ubi-base based on ubi10 (devfile#237) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> chore: Import certificates on the start (devfile#240) * chore: Import certificates on the start Signed-off-by: Anatolii Bazko <abazko@redhat.com> chore: set Node 20 as a default version (devfile#229) Signed-off-by: Valerii <vsvydenk@redhat.com> Update base ubi9 image to latest Update GH CLI release Update ripgrep Update bat Update fd Update kubedock Update base/ubi9/Dockerfile Fix the upstream Docker image identifier Co-authored-by: David Kwon <dakwon@redhat.com>
isuftin
added a commit
to isuftin/developer-images
that referenced
this pull request
Dec 12, 2025
feat: Use latest upstream UBI9 image, update kubedock and gh-cli Signed-off-by: Ivan Suftin <isuftin@usgs.gov> feat: Update /etc/sub*id files to support nested containers (devfile#232) * feat: Update /etc/sub*id files in order to run podman command in a user namespace Signed-off-by: Anatolii Bazko <abazko@redhat.com> feat: Use latest upstream UBI9 image, update kubedock and gh-cli (devfile#235) Signed-off-by: Ivan Suftin <isuftin@usgs.gov> Add ubi-base based on ubi10 (devfile#237) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> chore: Import certificates on the start (devfile#240) * chore: Import certificates on the start Signed-off-by: Anatolii Bazko <abazko@redhat.com> chore: set Node 20 as a default version (devfile#229) Signed-off-by: Valerii <vsvydenk@redhat.com> Update base ubi9 image to latest Update GH CLI release Update ripgrep Update bat Update fd Update kubedock Update base/ubi9/Dockerfile Fix the upstream Docker image identifier Co-authored-by: David Kwon <dakwon@redhat.com>
isuftin
added a commit
to isuftin/developer-images
that referenced
this pull request
Dec 12, 2025
feat: Use latest upstream UBI9 image, update kubedock and gh-cli Signed-off-by: Ivan Suftin <isuftin@usgs.gov> feat: Update /etc/sub*id files to support nested containers (devfile#232) * feat: Update /etc/sub*id files in order to run podman command in a user namespace Signed-off-by: Anatolii Bazko <abazko@redhat.com> feat: Use latest upstream UBI9 image, update kubedock and gh-cli (devfile#235) Signed-off-by: Ivan Suftin <isuftin@usgs.gov> Add ubi-base based on ubi10 (devfile#237) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> chore: Import certificates on the start (devfile#240) * chore: Import certificates on the start Signed-off-by: Anatolii Bazko <abazko@redhat.com> chore: set Node 20 as a default version (devfile#229) Signed-off-by: Valerii <vsvydenk@redhat.com> Update base ubi9 image to latest Update GH CLI release Update ripgrep Update bat Update fd Update kubedock Update base/ubi9/Dockerfile Fix the upstream Docker image identifier Co-authored-by: David Kwon <dakwon@redhat.com> Signed-off-by: Ivan Suftin <isuftin@usgs.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
eclipse-che/che#23555
Admin can add extra certificates by following the guide [1]
The problem is that those certificates are not automatically added to java key store
This PR improves that.
[1] https://eclipse.dev/che/docs/stable/administration-guide/importing-untrusted-tls-certificates/