Inline buildx global build and target platform envvars when resolving base image and user#1169
Open
trxcllnt wants to merge 1 commit intodevcontainers:mainfrom
Open
Inline buildx global build and target platform envvars when resolving base image and user#1169trxcllnt wants to merge 1 commit intodevcontainers:mainfrom
trxcllnt wants to merge 1 commit intodevcontainers:mainfrom
Conversation
… base image and user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the buildkit global platform ARGs are respected in
findBaseImage()andfindUserStatement()functions.These variables are valid in
FROMlines, e.g.:Without this change, the devcontainers CLI attempts to pull an image named
base-rather than continue to walk theFROMtree to findubuntu:latest.Fixes #275