Conversation
Reviewer's GuideRefactors the project layout by moving the cluster simulator, schedulers, wrappers, and related tests under a new src.server_simulator package namespace, updating all internal imports and references to match the new structure and keeping behavior unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
test_e2e_single_slot.pychange fromfrom src import envstoimport src.server_simulatoris inconsistent with the other e2e tests (import src.server_simulator.envs) and may no longer trigger env registration as intended; consider importing the envs subpackage explicitly for side-effects. - In
wrappers/cluster_simulator/render_wrapper.py,BaseClusterObservationis now imported fromsrc.server_simulator.envs.cluster_simulatorinstead of the observation module; verify that the package’s__init__exposes this symbol or restore the more direct module import to avoid accidental breakage.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `test_e2e_single_slot.py` change from `from src import envs` to `import src.server_simulator` is inconsistent with the other e2e tests (`import src.server_simulator.envs`) and may no longer trigger env registration as intended; consider importing the envs subpackage explicitly for side-effects.
- In `wrappers/cluster_simulator/render_wrapper.py`, `BaseClusterObservation` is now imported from `src.server_simulator.envs.cluster_simulator` instead of the observation module; verify that the package’s `__init__` exposes this symbol or restore the more direct module import to avoid accidental breakage.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Restructure the cluster simulator and scheduler modules under the new server_simulator package and update all imports accordingly.
Enhancements:
Tests:
Chores: