fix: create temp directory next to input file#4
Open
fredchu wants to merge 1 commit intodeusyu:mainfrom
Open
Conversation
Remove os.path.basename() so the temp dir preserves the input file's directory path. More intuitive when the input EPUB lives in ~/Downloads/ or another non-cwd location. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.path.basename()fromsetup_temp_directory()andmain()inconvert.py{filepath}_temp/next to the source file~/Downloads/or another non-cwd location从 PR #2 拆出来的第一项改动（temp 目录位置），按 review 建议单独提交。
Test plan
convert.pycompiles without errors🤖 Generated with Claude Code