Open
Conversation
* Add docker_scripts; updated Makefile and Dockerfile with support for multinode execution. * Add docker_scripts. * large change in scrape_libs.sh to fix issues when multiple libfabric.so libs are present; and, fixed missing python libs. * Created clean branch with all the changes need for ROCM 5.6 multi-node execution * Bumped version; updated CircleCI config targets. * removed 'a few extraneous comments.'
| @@ -0,0 +1,57 @@ | |||
| git_hash: <git_hash_here> | |||
Contributor
There was a problem hiding this comment.
I don't think I understand what this file is for, if it's got a git_hash embedded into it?
Contributor
rb-determined-ai
left a comment
rb-determined-ai
left a comment
There was a problem hiding this comment.
Overall, looks good to me so far.
To make sure I'm properly understanding the overall plan, we are going to:
a. improve our image naming
b. stop using determinedai/environments:... and use determinedai/the-image-name:... instead
c. only publish hash images from this repo
d. let the determined repo retag hashes into released versions
e. switch to NGC+ images
Is that accurate? It looks like this commit contains a. but not b., d., or e.
What is the overall roll-out plan for how we will deliver this feature to end-users with the fewest number of disruptions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change our image names to be more discoverable. Add a matrix for important package versions.
Checklist
bumpenvsprocedure in the determined repo. See README.