feat: deprecate estimateSize and use v8 serialisation directly#10
Merged
kt3k merged 1 commit intodenoland:mainfrom Jun 17, 2025
Merged
feat: deprecate estimateSize and use v8 serialisation directly#10kt3k merged 1 commit intodenoland:mainfrom
kt3k merged 1 commit intodenoland:mainfrom
Conversation
Contributor
|
published as 0.1.4 https://jsr.io/@deno/kv-utils@0.1.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy now supports accessing v8 serialize via
"node:v8"which means everywhere you would reasonable run Deno KV (including Bun) supports serialize from"node:v8". This effectively makes the functionality inPreviously, the performance in Deno of serialize was poor, but recent versions have it faster than the original estimation function:
Based on this,
estimateSizeis redundant and less accurate than using serialize directly and should be deprecated and eventually removed.