This repository was archived by the owner on Apr 2, 2026. It is now read-only.
fix: store Global<Context> ptr for libuv-compat callbacks#1315
Closed
littledivy wants to merge 2 commits intomainfrom
Closed
fix: store Global<Context> ptr for libuv-compat callbacks#1315littledivy wants to merge 2 commits intomainfrom
littledivy wants to merge 2 commits intomainfrom
Conversation
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Feb 27, 2026
Instead of storing a `v8::Local<Context>` pointer in `loop_.data` at the start of each event loop tick (which is only valid for that tick), store a `v8::Global<Context>` via `Global::into_raw()` once during `register_uv_loop`. V8 keeps the persistent-handle slot updated across GC cycles, so the pointer remains valid for the lifetime of the runtime. The raw Global is reconstructed and dropped in `JsRealmInner::destroy`. Ported from denoland/deno_core#1315 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
Member
|
Closing in favor of denoland/deno#32361 |
bartlomieju
added a commit
to denoland/deno
that referenced
this pull request
Feb 28, 2026
## Summary - Store a `v8::Global<Context>` via `Global::into_raw()` once during `register_uv_loop` instead of storing a `v8::Local<Context>` pointer at the start of each event loop tick - V8 keeps the persistent-handle slot updated across GC cycles, so the pointer remains valid for the lifetime of the runtime - The raw Global is reconstructed and properly dropped in `JsRealmInner::destroy` - Remove the per-tick `transmute` + `const` size assert that was previously needed Ported from denoland/deno_core#1315 Co-authored-by: Divy Srivastava <me@littledivy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.