Skip to content

next/previous item for normal mode#147

Open
staffler-xyz wants to merge 2 commits intodelannoyk:masterfrom
staffler-xyz:master
Open

next/previous item for normal mode#147
staffler-xyz wants to merge 2 commits intodelannoyk:masterfrom
staffler-xyz:master

Conversation

@staffler-xyz
Copy link
Copy Markdown

There seems to be a problem with previous/next in normal mode:

  1. previous/next should be always false for queues with one item
  2. when reaching the end of the list, the previous item returned should not be the last item

Maybe there is a better approach, this is just a suggestion 😀

@delannoykbot
Copy link
Copy Markdown

Danger has errored

[!] Invalid Dangerfile file: undefined local variable or method xcov for #<Danger::Dangerfile:0x00007fd869a71590>

 #  from Dangerfile:20
 #  -------------------------------------------
 #  # Asserts the test coverage meets the threshold
 >  xcov.report(scheme: 'AudioPlayer iOS', project: 'AudioPlayer/AudioPlayer.xcodeproj', minimum_coverage_percentage: 50)
 #  -------------------------------------------

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants