Skip to content

ci(machines): mark container mounts as safe git directories#588

Merged
njzjz merged 3 commits intodeepmodeling:masterfrom
njzjz-bot:fix/pr-587-safe-directory-container
Mar 29, 2026
Merged

ci(machines): mark container mounts as safe git directories#588
njzjz merged 3 commits intodeepmodeling:masterfrom
njzjz-bot:fix/pr-587-safe-directory-container

Conversation

@njzjz-bot
Copy link
Copy Markdown
Contributor

Problem

Change

Notes

Authored by OpenClaw (model: custom-chat-jinzhezeng-group/gpt-5.4)

Copilot AI and others added 3 commits March 29, 2026 13:09
The previous fix only marked the GitHub Actions workspace on the host
runner as safe for git. The failing setuptools/vcs-versioning build runs
inside containers where the repository is mounted at /dpdispatcher, so
git still rejects the repo as a dubious ownership checkout.

Mark the actual in-container repository mount as safe before installing
and building the package in the ssh, ssh_rsync, slurm, and pbs CI jobs.

Authored by OpenClaw (model: custom-chat-jinzhezeng-group/gpt-5.4)
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

Warning

Rate limit exceeded

@njzjz-bot has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 50 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 50 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 28324123-8674-4174-a9b3-195111022ba7

📥 Commits

Reviewing files that changed from the base of the PR and between f7541f8 and 571e25a.

📒 Files selected for processing (5)
  • .github/workflows/machines.yml
  • ci/pbs.sh
  • ci/slurm.sh
  • ci/ssh.sh
  • ci/ssh_rsync.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.33%. Comparing base (f7541f8) to head (571e25a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   48.33%   48.33%           
=======================================
  Files          40       40           
  Lines        3958     3958           
=======================================
  Hits         1913     1913           
  Misses       2045     2045           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the github_actions Pull requests that update GitHub Actions code label Mar 29, 2026
@njzjz njzjz requested a review from Copilot March 29, 2026 14:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes CI failures in the “machines” GitHub Actions workflow caused by Git’s “dubious ownership” protections when setuptools_scm introspects the repo inside containers mounted at /dpdispatcher.

Changes:

  • Add a workflow step to mark $GITHUB_WORKSPACE as a Git safe directory.
  • Update CI container scripts (ssh, ssh_rsync, slurm, pbs) to mark /dpdispatcher as a Git safe directory before installing/building.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ci/ssh.sh Configure /dpdispatcher as a safe Git directory inside the test container prior to install/test.
ci/ssh_rsync.sh Same safe-directory configuration inside the rsync-enabled test container.
ci/slurm.sh Configure /dpdispatcher as safe inside the Slurm controller container before build/test.
ci/pbs.sh Configure /dpdispatcher as safe inside the PBS master container before build/install.
.github/workflows/machines.yml Add workflow-level safe-directory config for the host runner workspace.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 29, 2026
@njzjz njzjz merged commit bc92147 into deepmodeling:master Mar 29, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants