Open
Conversation
elijahpetty
added
NoDocumentationNeeded
NoReleaseNotesNeeded
Contributor
No docs changes detected for 6407098 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds JS API documentation for plot axis-related types to improve generated docs/TypeScript API clarity.
Changes:
- Added class-level Javadoc to plot numeric-enum wrappers (axis type/position/format type, series plot style).
- Added field-level Javadoc to
JsAxisDescriptordescribing each axis configuration property and referencing the corresponding plot enums where applicable.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/client-api/src/main/java/io/deephaven/web/client/api/widget/plot/enums/JsSeriesPlotStyle.java | Adds class-level Javadoc describing the numeric enum purpose. |
| web/client-api/src/main/java/io/deephaven/web/client/api/widget/plot/enums/JsAxisType.java | Adds class-level Javadoc describing axis role enum. |
| web/client-api/src/main/java/io/deephaven/web/client/api/widget/plot/enums/JsAxisPosition.java | Adds class-level Javadoc describing axis position enum. |
| web/client-api/src/main/java/io/deephaven/web/client/api/widget/plot/enums/JsAxisFormatType.java | Adds class-level Javadoc describing axis formatting enum. |
| web/client-api/src/main/java/io/deephaven/web/client/api/widget/plot/JsAxisDescriptor.java | Adds comprehensive field-level Javadoc for axis configuration properties. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.